Added scancode defines to LUFA
Monday, October 11th, 2010This was a much needed contribution to make in my opinion, despite being a small one. I feel great about it, LUFA is a very nice piece of software.
/me reading
This was a much needed contribution to make in my opinion, despite being a small one. I feel great about it, LUFA is a very nice piece of software.
I've had to do some album art related work and I had to write a patch for the command line variant of the Album Art Downloader utility. You can also check out the related discussion.
The previous week was a notable one, since I created and sent the first patch of my life. I wonder why it took so long to make my first patch. Maybe I just wasn’t motivated enough to contribute on this level before, hell knows. This patch has borned out of an itch of mine as usual among developers. I love XChat and use it on a daily basis, it even starts with my session. However I relatively rarely use it, just when I need to answer some things or ask about an issue. So I wanted XChat to start minimized in the tray and provide a convinient way to hide / unhide. The latter issue wasn’t as easy as it ideally could be because one had to double click with the left mouse button instead of single clicking.
You gotta see it to believe:
My patch works against the version 2.4.5 of the XChat SysTray Integration Plugin. The maintainer of the plugin, Patrizio Bassi didn’t make any promises to include my code into the project, because I implemented the button changing functionality a different way that he wanted. He proposed a more general solution, but that would involve to much widgetry to be done with pure GTK+ in C without Glade and I didn’t want to do that. It’s very exhausting to write imperative code for declarative applications especially in a low-level language like C and I don’t have time for that. I’ve tried to align my coding style to his style, although his seems pretty bad which he agrees with. :-)
As a last note, my patch is considerably bigger than it could be. That’s because the source of the XChat Systray Integration Plugin contains mixed tabs and spaces. That pisses me off pretty much. I have to investigate this issue because it’s a major pain in the case of many projects.